search

MatrexsVigil / harvestcraft

All rights reserved - None of my artwork is available to be used for FREE in your game EVER. If you want to HIRE ME, please contact me. Thank you. This code is here for people to learn from and to help find bugs ONLY.
https://www.patreon.com/pamsmods
89 stars 85 forks source link

[1.12.2] Tree saplings not plantable on BoP grass blocks #272

Closed TimGoll closed 5 years ago

TimGoll commented 6 years ago

Latest forge, latest BoP and latest harvestcraft

Skaphegor commented 6 years ago

Do not use "latest". Post the version you used. If someone will read this later, the version cannot be reconstructed.

NielsPilgaard commented 5 years ago

This is still an issue

Versions

Skaphegor commented 5 years ago

All recommend to implement a check for oredict entries such as "dirt" and "grass".

Ricket commented 5 years ago

This appears to be the method that needs fixing:

https://github.com/MatrexsVigil/harvestcraft/blob/2913b289c3cf7486b6abb5bffd0c387cca5cad3e/src/main/java/com/pam/harvestcraft/blocks/growables/BlockPamSapling.java#L110-L112

~And this location should probably be fixed simultaneously, if it is similarly broken (not sure if BoP grass/dirt is a subclass of BlockGrass/BlockDirt or not -- this is ground traps checking for whether they are surrounded by dirt or grass)~

https://github.com/MatrexsVigil/harvestcraft/blob/2913b289c3cf7486b6abb5bffd0c387cca5cad3e/src/main/java/com/pam/harvestcraft/tileentities/TileEntityGroundTrap.java#L130-L132

EDIT: I tested, the ground trap does detect BoP grass as valid grass. So this second thing is not an issue.

TimGoll commented 5 years ago

The second check for the GroundTrap is way better because BOP extends the grass and dirt block of minecraft