search

MatrexsVigil / phc2crops

All rights reserved - None of my artwork is available to be used for FREE in your game EVER. If you want to HIRE ME, please contact me. Thank you. This code is here for people to learn from and to help find bugs ONLY.
https://www.patreon.com/pamsmods
Other
16 stars 23 forks source link

Right Click harvesting stops fertilizer use #39

Open ghost opened 3 years ago

ghost commented 3 years ago

Forge 36.1.2 pamhc2crops-1.16.3-1.0.1

With Right Click harvesting enabled, you can't use fertilizers such as industrial foregoing fertilizer on crops that aren't fully grown. Bonemeal works fine

Reproduce: Enable Right Click harvesting in config plant a crop, I used potatoes, use industrial foregoing fertilizer on crop, nothing happens. Expected crop to grow same as using bonemeal

I think its line 52 of CropHarvest.Java: if hand is not empty then cancel the event ?

Instead of generating the drops yourself, In my mod I use worldIn.destroyBlock. I'm new to modding so don't know if this is correct. But it plays the sound, particles and makes the drops

Instead of checking for just bonemeal maybe check if the item is in Forge:fertilizer tag then return?

UnicornSnuggler commented 3 years ago

I was going to report an issue that seems tangentially — if not exactly — related to this one. See here for more information.