Timing issues - Githubissues

Matriks404 / openSMB2

An open source reimplementation of Super Mario Bros. 2 written in Lua and LÖVE.

GNU General Public License v3.0

33 stars 4 forks source link

Timing issues #5

Open Matriks404 opened 6 years ago

Matriks404 commented 6 years ago

[x] Timing in intro story is not correct (music ends too early, NES one ends just as last line of text appears.
[x] Physics and some graphics routines update separately and this is wrong! We should use delta time or something.
[ ] Check wether or not everything is timed correctly.

Matriks404 commented 6 years ago

Just a note: we should compare recording of NES game and our engine and see what's wrong.

Matriks404 commented 6 years ago

improved timing slightly in https://github.com/Matriks404/openSMB2/commit/72c6391da2937200c41071ba62dc5c7cb20ba4f1

Still incorrect though, it's hard to compare and measure results as my engine has constantly different timing (inconsistent framerate?). I will try to fix this later, with better computer.

Matriks404 commented 6 years ago

It looks like VSync doesn't affect love.update (as it should), so timing is freaking wrong, we should compute everything in 1/60th of a second, and graphics could probably have VSync turned off.

Matriks404 commented 1 year ago

Generally fixed in 70d74e8c812b5d76de9157b1f32b3949fe118fc0.