search

MatrixAI / Polykey-CLI

Polykey CLI - Open Source Decentralized Secret Sharing System for Zero Trust Workflows
https://polykey.com
GNU General Public License v3.0
6 stars 3 forks source link

Discovering node using github identity or nodeID is failing #280

Open shafiqihtsham opened 2 months ago

shafiqihtsham commented 2 months ago

Describe the bug

I am on version 0.7.1 and brynley is on version 0.6.3. I am trying to discover her node using her nodeID as well as through github but the command is failing.

image

To Reproduce

  1. start pk agent
  2. try to discover node either using polykey identities discover github.com:brynblack or node id.

Expected behavior

It should discover the identity.

Screenshots

image image

Platform (please complete the following information)

Additional context

Verbose output of agent and command. image image

image

Notify maintainers

linear[bot] commented 2 months ago

ENG-407 Discovering node using github identity or nodeID is failing

tegefaulkes commented 2 months ago

The additional context shows that the command succeeded that time. Include a screenshot of identities list showing the nodeid still missing from the gestalt.

The agent logs shows that it failed to connect to the node when discovering it. Check if you can ping the node as well with nodes ping and show the output.

shafiqihtsham commented 2 months ago

The additional context shows that the command succeeded that time. Include a screenshot of identities list showing the nodeid still missing from the gestalt.

The agent logs shows that it failed to connect to the node when discovering it. Check if you can ping the node as well with nodes ping and show the output.

Ok, for some reason it was working yesterday, but today it is failing, image

tegefaulkes commented 2 months ago

Depends if @brynblack node is still running. We'll have to run through some debug steps all at once to work out what's happening.

tegefaulkes commented 2 months ago

I did some testing with @shafiqihtsham directly and found the problem.

Its a combination of two factors.

  1. Ed's laptop runs a little slow. It seems to be a bit less powerful despite being the same model of 3480.
  2. It's running into the timeout when processing the vertex. This is 2 seconds currently but it should be a bit higher than that.

The simplest fix is two fold.

  1. Increase the timeout from 2 seconds to something more reasonable for slower machines.
  2. While there is an error message we may need to update it to be more clear. Possibly include the failure reason in the --monitor output of the identities discover command.
CMCDragonkai commented 2 months ago

I was talking about @shafiqihtsham that this:

  1. Needs to be a system configuration parameter. Not hardcoded there.
  2. Needs to be determined empirically through measuring the most likely failure. P99 and all.