Closed tegefaulkes closed 5 months ago
The readable-stream is also being used by EFS. That can't really be changed, it has to simulate node streams. However it's a really old readable stream. Might be better upgraded to match the latest stream behaviour. Not sure.
I'm putting this under #298 because the usage of readable streams is relevant to git and EFS which is still using the old readable stream implementation in order to simulate how Node streams work, but Node streams have changed quite a bit since the initial import from VFS.
Ok vaults domain should be using web streams, same with git. The git domain needs significant refactoring.
The EFS has to continue using "fs streams", it just requires an update to the fs stream backing library, and then testing to see that everything still works.
Ok vaults domain should be using web streams, same with git. The git domain needs significant refactoring.
The EFS has to continue using "fs streams", it just requires an update to the fs stream backing library, and then testing to see that everything still works.
This might actually be addressed by the #709 PR, I'll double check and include this issue as fixed if so.
Yes so if this is done, remove the dependency from package.json too. It will continue to be used by EFS until it can be refactored too.
I double checked and it's all gone. I've removed the dependency in #709 and made it fixed by that as well.
Specification
Some parts of the code are still using
readable-stream
. these need to be replaced with webstreams and thereadable-stream
dependency removed from thepackage.json
.These usages can be found at
Additional context
Tasks
readable-stream
usage withstream/web
.~ - replacing with async generatorreadable-stream
as a dependency from thepackage.json
.