search

MatrixAI / Polykey

Polykey Core Library - Open Source Decentralized Secret Sharing System for Zero Trust Delegation of Authority
https://polykey.com
GNU General Public License v3.0
27 stars 4 forks source link

Minor review and refactor of vaults domain for 'polykey' #718

Closed tegefaulkes closed 1 week ago

tegefaulkes commented 2 weeks ago

Specification

As part of refactoring the git domain in #298 we need to do a small review of the vaults domain for any fixes and improvements. This is a general refactor and review. We're looking for any places that can be tidied up if needed. Some tests need to be re-enabled as well.

Additional context

Tasks

  1. General review of the vaults domain.
  2. Have a closer look at the vaults committing secrets and git garbage collection code.
  3. Determine and apply any optimisations that can be made.
  4. Review vaults tests and clean them up if needed.
  5. Re-enable any tests that have been disabled.
  6. Possibly split up some test files so the vaults domain runs quicker in CI. vault ops is currently very slow.
linear[bot] commented 2 weeks ago

ENG-316 Minor review and refactor of vaults domain for 'polykey'

tegefaulkes commented 1 week ago

Yeah, there's definitely some weird interaction with linear going on here.

CMCDragonkai commented 1 week ago

You got to be more descriptive with your issue title in the future...