search

MatrixAI / js-encryptedfs

Encrypted Filesystem for TypeScript/JavaScript Applications
https://polykey.com
Apache License 2.0
10 stars 3 forks source link

TypeScript migration #13

Closed robert-cronin closed 4 years ago

robert-cronin commented 4 years ago

Fixes #14.

robert-cronin commented 4 years ago

@CMCDragonkai

CMCDragonkai commented 4 years ago

All PRs and MRs are meant to be linked to a particular issue that they are resolving. Currently there isn't an issue in this repo that is for the typescript migration.

But we should do this in stages.

Make this PR focus on migrating to typescript and only that (and to change to using the JavaScript-Demo architecture "typescript" branch).

Once that is done, we merge this, and we can put in the async issue into a separate MR.

CMCDragonkai commented 4 years ago

I've added #14. I think you said the TS migration is already done. So can we merge that portion of work on Monday, and extract out the extra work on the async things into a new MR targeting #4.

CMCDragonkai commented 4 years ago

You need to remember to set the metadata of PRs. See on the right.

CMCDragonkai commented 4 years ago

I'll review this tonight. But after review, squash into 1 commit.

CMCDragonkai commented 4 years ago

I've removed the javascript-demo. That is just an example from JS Demo. But also updated the tsconfig.json to match how we do it in other apps. Please try this.

Also can move the tests back into a tests directory? And if you can do any test based IO with fs.mkdtemp directory instead of inside the test directory.

CMCDragonkai commented 4 years ago

I've moved js-virtualfs back into dependencies because it shouldn't be bundled in by default when we export commonjs modules.

Furthermore, because the webpack config has changed as well. @robert-cronin you need to try rebuilding using webpack to see if the config works as normal as before.

CMCDragonkai commented 4 years ago

Once this is merged, make sure to rebase #15 on this.

CMCDragonkai commented 4 years ago

Confirm that builds still work, and check if package.json fields main, module, browser matches what is outputted in dist directory. And then if that's true. Squash and merge.