search

MatrixAI / js-encryptedfs

Encrypted Filesystem for TypeScript/JavaScript Applications
https://polykey.com
Apache License 2.0
10 stars 3 forks source link

Conform to fs interface #33

Closed robert-cronin closed 4 years ago

robert-cronin commented 4 years ago

This issue will make EFS conform to the fs interface by, at a minimum, separating promise based methods into a separate promise API. This is motivated by the fact that we need a callback wrapper over EFS in order to work with isomorphic-git in js-polykey.

Fixes #30 Fixes #32 Fixes #34

CMCDragonkai commented 4 years ago

A quick look, but I'm going to assume you did this well. So merge when you are ready.

robert-cronin commented 4 years ago

there is still a few minor things I need to do like update the testing but I will merge after that

robert-cronin commented 4 years ago

This has now been updated to callback and promise methods according to the nodejs fs interface. It works well in isomorphic git as a PromiseClient as well. I will merge this shortly.

Edit: gitlab CI/CD pipeline for latest commit is passed