emmacasolin
commented
2 years ago The ErrorEncryptedEFSError has additional properties on top of those from AbstractError, so its toJSON and fromJSON need to be adjusted accordingly. This also involves modifying the constructor, since it didn't take a message parameter.
The constructor is now
constructor(
{
errno,
message,
path,
dest,
syscall,
}: {
errno: {
errno: number;
code: string;
description: string;
};
message?: string;
path?: string;
dest?: string;
syscall?: string;
},
options: {
timestamp?: Date;
data?: POJO;
cause?: T;
} = {},
) {
if (message == null) {
message = errno.code + ': ' + errno.description;
if (path != null) {
message += ', ' + path;
if (dest != null) message += ' -> ' + dest;
}
}
super(message, options);
this._errno = errno.errno;
this._code = errno.code;
this._description = errno.description;
this._syscall = syscall;
}So if we're reconstructing the error inside fromJSON we can pass in the message property.
And the toJSON/fromJSON are as follows:
public toJSON(): any {
const json = super.toJSON();
json.data._errno = this._errno;
json.data._code = this._code;
json.data._description = this._description;
json.data._syscall = this._syscall;
return json;
}
public static fromJSON<T extends Class<any>>(
this: T,
json: any,
): InstanceType<T> {
if (
typeof json !== 'object' ||
json.type !== this.name ||
typeof json.data !== 'object' ||
typeof json.data.message !== 'string' ||
isNaN(Date.parse(json.data.timestamp)) ||
typeof json.data.data !== 'object' ||
typeof json.data._errno != 'number' ||
typeof json.data._code != 'string' ||
typeof json.data._description != 'string' ||
!('cause' in json.data) ||
('stack' in json.data && typeof json.data.stack !== 'string') ||
('_syscall' in json.data && typeof json.data._syscall !== 'string')
) {
throw new TypeError(`Cannot decode JSON to ${this.name}`);
}
const e = new this({
errno: {
errno: json.data._errno,
code: json.data._code,
description: json.data._description,
},
message: json.data.message,
syscall: json.data._syscall,
},
{
timestamp: new Date(json.data.timestamp),
data: json.data.data,
cause: json.data.cause,
});
e.stack = json.data.stack;
return e;
}
CMCDragonkai
Description
@matrixai/errors was upgraded to include
toJSONandfromJSONto help with error serialisation/deserialisation. This has been updated here (along with other dependencies), along with upgrading to Node 16 to align with other Matrix AI packages.Tasks
Final checklist