MatrixAI / js-logger

TypeScript/JavaScript Logger Library
https://polykey.com
Apache License 2.0
1 stars 0 forks source link

ci: merge staging to master #19

Closed MatrixAI-Bot closed 2 years ago

MatrixAI-Bot commented 2 years ago

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

MatrixAI-Bot commented 2 years ago

Pipeline Attempt on 592699755 for 534b2c2a1c5ab77c5af30af95626124b08a4f41d

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/592699755

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=19&src=https%3A%2F%2Fgithub.com%2FMatrixAI%2Fjs-logger)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

CMCDragonkai commented 2 years ago

Currently there's a failure on windows: https://gitlab.com/MatrixAI/open-source/js-logger/-/jobs/2748280466.

[Error: ENOTEMPTY: directory not empty, rmdir 'C:\Users\GITLAB~1\AppData\Local\Temp\logger_handlers-GtJEbz'] {
  errno: -4051,
  code: 'ENOTEMPTY',
  syscall: 'rmdir',
  path: 'C:\\Users\\GITLAB~1\\AppData\\Local\\Temp\\logger_handlers-GtJEbz'
}

It's possible that fs.rm with recursive doesn't work on windows.

MatrixAI-Bot commented 2 years ago

Pipeline Attempt on 593021978 for e2985dd6d851b1d83d8c8c98cbdf260b7abc8ac5

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/593021978

MatrixAI-Bot commented 2 years ago

Pipeline Attempt on 593035381 for 42829046c9ab2a4a8933a7d0a2868ca135627608

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/593035381

MatrixAI-Bot commented 2 years ago

Pipeline Attempt on 593035969 for 8a1713a052c240d9277d6f881406587e4578a4b5

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/593035969

MatrixAI-Bot commented 2 years ago

Pipeline Succeeded on 593035969 for 8a1713a052c240d9277d6f881406587e4578a4b5

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/593035969

CMCDragonkai commented 2 years ago

The windows problem is strange, but it fixed after I both forced the deletion and also ensured that I closed the standard stream. Windows does require standard streams to be closed prior to deleting the directory, but on matrix-win-1, it was a EPERM error not ENOTEMPTY. At any case it's passing now...