MatrixAI / js-logger

TypeScript/JavaScript Logger Library
https://polykey.com
Apache License 2.0
1 stars 0 forks source link

ci: merge staging to master #32

Closed MatrixAI-Bot closed 10 months ago

MatrixAI-Bot commented 10 months ago

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

MatrixAI-Bot commented 10 months ago

Pipeline Attempt on 1064693194 for 132a5eb524952b26c4b3a9b74e284fa1f247e635

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1064693194

MatrixAI-Bot commented 10 months ago

Pipeline Attempt on 1064693201 for a138acaa7626a854ee84823d5660faf077f88e83

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1064693201

ghost commented 10 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/MatrixAI/js-logger/32/c70dc0d3/00943e04589ab43c5e1f57ad30b3e495e054ea92.svg)](https://app.codesee.io/r/reviews?pr=32&src=https%3A%2F%2Fgithub.com%2FMatrixAI%2Fjs-logger) #### Legend CodeSee Map legend
CMCDragonkai commented 10 months ago

Same windows problem, have to clear runner cache.

But also I don't like the fact that by removing the child loggers, you now can create duplicate loggers.

You say changing it is a major change, but literally it is a major change because you are now creating new loggers every time.

Therefore you need to explain what downstream problems are there here, and I believe they need to be fixed. Cannot paper over this, this is a critical problem.

MatrixAI-Bot commented 10 months ago

Pipeline Attempt on 1070789219 for 00943e04589ab43c5e1f57ad30b3e495e054ea92

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1070789219

MatrixAI-Bot commented 10 months ago

Pipeline Succeeded on 1070789219 for 00943e04589ab43c5e1f57ad30b3e495e054ea92

https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1070789219