Closed MatrixAI-Bot closed 10 months ago
Pipeline Attempt on 1064693194 for 132a5eb524952b26c4b3a9b74e284fa1f247e635
https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1064693194
Pipeline Attempt on 1064693201 for a138acaa7626a854ee84823d5660faf077f88e83
https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1064693201
Same windows problem, have to clear runner cache.
But also I don't like the fact that by removing the child loggers, you now can create duplicate loggers.
You say changing it is a major change, but literally it is a major change because you are now creating new loggers every time.
Therefore you need to explain what downstream problems are there here, and I believe they need to be fixed. Cannot paper over this, this is a critical problem.
Pipeline Attempt on 1070789219 for 00943e04589ab43c5e1f57ad30b3e495e054ea92
https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1070789219
Pipeline Succeeded on 1070789219 for 00943e04589ab43c5e1f57ad30b3e495e054ea92
https://gitlab.com/MatrixAI/open-source/js-logger/-/pipelines/1070789219
This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.