Open CMCDragonkai opened 1 month ago
One way to get around this warning is potentially doing all the work in the C++ level? One way to do this is pass the reference to the JS socket object to the native code side, and get the native code to do the necessary referencing of the underlying FD.
Also can we start changing all our native code to Rust to align with js-quic and js-exec? I know js-db is still pending, but it's usually better.
Look at node native code docs as to how to directly interact with socket objects.
Describe the bug
Inside
MDNS.ts
, it's using_handle
in a few places. In particular:The usage of
_handle
in theSocket
prototype causes warnings.It looks like this in PK CLI:
Right after starting the agent.
Find an alternative way to do the above, or we need some way of disabling the warning? This is some sort of internal property right?
Apparently Node allows disabling warnings on startup.
To Reproduce
polykey agent start
Expected behavior
No warnings should occur.
Additional context
Notify maintainers
@amydevs