MatrixAI / js-quic

QUIC Networking for TypeScript & JavaScript
https://matrixai.github.io/js-quic/
Apache License 2.0
13 stars 1 forks source link

fix: we now abort starting connection when stopping the `QUICServer` #103

Closed tegefaulkes closed 3 months ago

tegefaulkes commented 3 months ago

[ci skip]

Description

This PR addresses the issue where stopping a QUICServer with a starting QUICConnection will wait out the timeout of the connection without forcing it to stop. The solution to this is to provide QUICServer wide abort signal to be passed into QUICConnections when they're being created. This abort signal has been modified with setMaxListiners to prevent warnings for more than 11 listeners since it's a 1 signal to many connections.

The QUICClient doesn't need the same treatment for two reasons. First, there is 1 connection per client. Second, it's not possible to stop the client without fully creating the client and connection first.

Issues Fixed

Tasks

Final checklist

linear[bot] commented 3 months ago

ENG-328 Server should abort starting connections when stopping with `force: true`