MatrixAI / js-quic

QUIC Networking for TypeScript & JavaScript
https://matrixai.github.io/js-quic/
Apache License 2.0
13 stars 1 forks source link

optional servername via config #106

Closed gherkins closed 2 months ago

gherkins commented 3 months ago

Description

Add possibility to provide servername via config. This needs to be configurable for example in solana tpu transactions, where the servername has to be a specific string

Issues Fixed

partial fix of: https://github.com/MatrixAI/js-quic/issues/98#issuecomment-2156744139

CMCDragonkai commented 3 months ago

Thanks for this.

Generally the assumption was that the server name and host is the same thing.

However given that they can be different. I think simply extending Qui client with an additional optional hostname parameter would be sufficient.

If it is passed, it is used as the server name.

However host also could be a hostname... So let's see.

tegefaulkes commented 3 months ago

I'll have a deeper look into it when I have a free moment.

lmvdz commented 2 months ago

Bump, feels like a very small change...