search

MatrixAI / js-quic

QUIC Networking for TypeScript & JavaScript
https://matrixai.github.io/js-quic/
Apache License 2.0
13 stars 1 forks source link

ci: merge staging to master #43

Closed MatrixAI-Bot closed 1 year ago

MatrixAI-Bot commented 1 year ago

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

MatrixAI-Bot commented 1 year ago

Pipeline Attempt on 971828498 for 8f7c8178ca31043d3d7b1e179d47650c4b0d3ce6

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971828498

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/MatrixAI/js-quic/43/0c9dc219/a0f40edace764bc322fc03f8190cb1d7f4d31fbc.svg)](https://app.codesee.io/r/reviews?pr=43&src=https%3A%2F%2Fgithub.com%2FMatrixAI%2Fjs-quic) #### Legend CodeSee Map legend
MatrixAI-Bot commented 1 year ago

Pipeline Attempt on 971838916 for af55609019da3c15ebf17885a3b915ce3d39612d

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971838916

MatrixAI-Bot commented 1 year ago

Pipeline Succeeded on 971828498 for 8f7c8178ca31043d3d7b1e179d47650c4b0d3ce6

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971828498

MatrixAI-Bot commented 1 year ago

Pipeline Succeeded on 971838916 for af55609019da3c15ebf17885a3b915ce3d39612d

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971838916

CMCDragonkai commented 1 year ago

There is a problem with pvtsutils from 1.3.3 onwards. Pinning to 1.3.2 solves the problem for running tests.

This problem also exists in PK when we update the libraries. Upstream issue tracks this problem: https://github.com/PeculiarVentures/pvtsutils/issues/12

Will need to also pin pvtsutils to 1.3.2 in PK too.

CMCDragonkai commented 1 year ago

The weird situation where package-lock.json wasn't updated in the version script seems to have disappeared.

MatrixAI-Bot commented 1 year ago

Pipeline Attempt on 971863680 for a0f40edace764bc322fc03f8190cb1d7f4d31fbc

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971863680

MatrixAI-Bot commented 1 year ago

Pipeline Attempt on 971863690 for 9c201175c0470e2fb19a2482e6ab061daf09ec36

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971863690

MatrixAI-Bot commented 1 year ago

Pipeline Succeeded on 971863690 for 9c201175c0470e2fb19a2482e6ab061daf09ec36

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971863690

MatrixAI-Bot commented 1 year ago

Pipeline Succeeded on 971863680 for a0f40edace764bc322fc03f8190cb1d7f4d31fbc

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971863680

CMCDragonkai commented 1 year ago

Ok the problem with package-lock.json is that won't update with the optional dependencies because they haven't yet been released on NPM.

It doesn't cause an issue for downstream packages because only package.json is actually used. But package-lock.json is a bit annoying.

The solution to this can be that after the last commit, to trigger the CI to proceed to build and release the optional packages.

Then afterwards, when that is done, we update our version using npm version and then proceed to release the main package.

This is a bit annoying because it involves going back and forth between the CI and development to complete the entire release process.

Plus the CI might take time, since it has to run through all the tests too.

A long term solution might be to change up our release procedure so that versioning occurs in the CI itself rather than us creating version tags during development. (The problem being that sometimes this is good idea to have that flexibility like when prereleasing a feature branch).

This isn't really a huge problem right now, will create an issue. It's a general problem affecting any project that might have optional dependencies in this structure, and currently js-db isn't affected because it hasn't migrated to this style yet.