Change Server to start/stop from create/destroy

MatrixAI / js-rpc

Stream-based JSON RPC for JavaScript/TypeScript Applications

https://polykey.com

Apache License 2.0

4 stars 0 forks source link

Change Server to start/stop from create/destroy #32

Closed addievo closed 1 year ago

addievo commented 1 year ago

Description

The goal of this PR is to replace the server create/destroy with start/stop, as logically, starting and stopping makes more sense in Polykey as other layers such as QUIC and WS operate on start/stop.

Tasks

[x] 1. Create new events.
[x] 2. Replace events.
[x] 3. Refactor function names

Final checklist

[x] Domain specific tests
[x] Full tests
[x] Updated inline-comment documentation
[x] Lint fixed
[x] Squash and rebased
[x] Sanity check the final build

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/MatrixAI/js-rpc/32/e951ba4a/f0332c906318c626eb10ae83303a7392acc915bb.svg)](https://app.codesee.io/r/reviews?pr=32&src=https%3A%2F%2Fgithub.com%2FMatrixAI%2Fjs-rpc) #### Legend CodeSee Map legend

CMCDragonkai commented 1 year ago

Did you bring in HandlerTypes?

CMCDragonkai commented 1 year ago

Change RPCClient to just regular constructor, no need for any CreateDestroy anymore. Remove all destroy events.