Closed amydevs closed 2 months ago
https://github.com/webpack/webpack/discussions/13585
How i got perf_hooks working ^
https://github.com/webpack/webpack/discussions/13585
How i got perf_hooks working ^
That's a downstream thing right? Not something this repo would do. Because it produces an npm package.
However you can update the readme to explain too.
@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.
@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.
No we shouldn't preemptively polyfill. So readme it is.
Did you read my review?
Description
Allows
WebSocketClient
andWebSocketConnection
to work with the browserWebSocket
implementation.To note some discoveries:
Buffer
perf_hooks
with the browserperformance
API to work with browsers.Issues Fixed
Tasks
WebSocketClient
work with browserWebSocket
sWebSocketConnection
work with browserWebSocket
sWebSocket
usingws
library.Final checklist