MatrixAI / js-ws

Websocket Transport Library for TypeScript/JavaScript Applications
https://matrixai.github.io/js-ws/
Apache License 2.0
2 stars 0 forks source link

feature: isomorphic `WebSocket` support #32

Closed amydevs closed 2 months ago

amydevs commented 2 months ago

Description

Allows WebSocketClient and WebSocketConnection to work with the browser WebSocket implementation.

image

To note some discoveries:

Issues Fixed

Tasks

Final checklist

amydevs commented 2 months ago

https://github.com/webpack/webpack/discussions/13585

How i got perf_hooks working ^

CMCDragonkai commented 2 months ago

https://github.com/webpack/webpack/discussions/13585

How i got perf_hooks working ^

That's a downstream thing right? Not something this repo would do. Because it produces an npm package.

However you can update the readme to explain too.

amydevs commented 2 months ago

@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.

CMCDragonkai commented 2 months ago

@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.

No we shouldn't preemptively polyfill. So readme it is.

Did you read my review?