search

MatrixDJ96 / EZBlocker2

EZBlocker 2 - Ad muter/blocker for Spotify
GNU General Public License v3.0
141 stars 16 forks source link

Block ads option doesn't seem to be working correctly.. #5

Closed JourneyOver closed 6 years ago

JourneyOver commented 6 years ago

Using the "block ads" option from ezblocker2 doesn't seem to either pull in the full host edit that it should or something else is going on, as upon using it it'll still allow ads through on spotify. If I go and manually edit my host file to use the same host edits* from FadeMind repo for spotify then spotify will no longer have any ads whats so ever. Any idea on why this is happening?

MatrixDJ96 commented 6 years ago

I don't use FadeMind repo because some servers that are needed to play music

JourneyOver commented 6 years ago

well you was crediting

Steven Black for hosts patches

which is the one that's on fademinds repo so I thought you was using it. *which btw I haven't had any issues using.

Either way your host patch doesn't block ads at all, as ads still get through if I use your "block ads" option so just thought I'd give you a heads up.

MatrixDJ96 commented 6 years ago

Check this out: https://github.com/CHEF-KOCH/Spotify-Ad-free/issues/2

And this: https://github.com/CHEF-KOCH/Spotify-Ad-free/blob/master/do%20not%20block.txt

JourneyOver commented 6 years ago

Well I don't use the web player nor do I use the phone app, so I can't really say much for either of those. I use the desktop app and haven't had a single issue though while using fademinds host edits for spotify and I've been using them ever since he created them.

Anyways like I said before just wanted to give you a heads up, but you should either remove the whole "block ads" option or fix it or at least change the option name to something that actually reflects what it does because as right now it's just misleading since it doesn't do what the option actually says it does.

MatrixDJ96 commented 6 years ago

Check with new version

MatrixDJ96 commented 6 years ago

Try this: EZBlocker2 TEST.zip (It contains latest commit about hosts patches)

JourneyOver commented 6 years ago

I actually forgot all about this, honestly just going to close it as I have since stopped using this as I (dunno why I didn't think about this earlier) have no need for it with my host edits..