search

Matroska-Org / foundation-source

libEBML2, libMatroska2, mkvalidator, mkclean and the specifications
55 stars 29 forks source link

create C++-style enums, not C-style #109

Closed mbunkus closed 1 year ago

robUx4 commented 1 year ago

Please do not merge code I'm maintaning without giving me a change to agree or disagree. As I said elsewhere, I want to keep this code generator the same between libmatroska and libmatroska2. That implies the enums being typedefs.

mbunkus commented 1 year ago

Sorry, I wasn't aware of that. I'll revert both the change here & in libMatroska.

mbunkus commented 1 year ago

Reverted directly via ea57e9e50c570e94ee5ba6fb02cec476b72d7f33 without a PR. same for libMatroska.

robUx4 commented 1 year ago

Technically I would like to make a single file for both libraries (on generator). I quikly added it to KaxSemantic.h because it was the fastest option.

robUx4 commented 1 year ago

It's not blocking the release though. It can be added later and included from KaxSemantic.h for backward compatibility.