deprecate the Min/Max pseudo-cache values

Matroska-Org / libmatroska

a C++ libary to parse Matroska files (.mkv and .mka)

GNU Lesser General Public License v2.1

318 stars 57 forks source link

deprecate the Min/Max pseudo-cache values #102

Closed robUx4 closed 1 year ago

robUx4 commented 1 year ago

See https://github.com/ietf-wg-cellar/matroska-specification/pull/705

Don't think it qualifies as an API break since the method was already there.

mbunkus commented 1 year ago

In general I'm fine with the change. It will require some smaller changes to MKVToolNix, though:

mkvpropedit & the GUI's header editor still allow changing both properties; that'll have to be removed
both programs always have to re-write the whole track master element which will fail if the original file contains those two properties (my test suite has such files); the programs will have to remove both elements from the masters before writing them, I guess

mbunkus commented 1 year ago

Changes to MKVToolNix are done. Merged.

robUx4 commented 1 year ago

OK, that means the next mpkvpropedit will require a new libmatroska version ?

mbunkus commented 1 year ago

No. I simply removed support for modifying the elements & enabled removing them from master elements that have otherwise been modified. All of that simply avoids calling the Render methods of the elements. That'll work with both existing releases & the current master branch.

mbunkus commented 1 year ago

To expand a bit further: I take great care to have MKVToolNix be compilable with both the current existing releases & the current master branches of both libraries.