search

Matroska-Org / libmatroska

a C++ libary to parse Matroska files (.mkv and .mka)
GNU Lesser General Public License v2.1
318 stars 57 forks source link

allow writing the upper signed VINT boundary #106

Closed robUx4 closed 1 year ago

robUx4 commented 1 year ago

We should have no problem reading them in older version of libmatroska (rather libebml).

Draft on top of #105.

@mbunkus can you check this is working for you, so we can merge https://github.com/ietf-wg-cellar/matroska-specification/pull/733

mbunkus commented 1 year ago

I'm confused. Isn't this the same as #105 which I've merged earlier today?

mbunkus commented 1 year ago

Ah no, there's an additional commit. Sorry!

robUx4 commented 1 year ago

I verified that the new shorter values for the upper boundaries are properly read with current libebml, using the code found here https://github.com/ietf-wg-cellar/matroska-specification/issues/726#issuecomment-1465207032.

So this MR should be safe.

mbunkus commented 1 year ago

Seems to work fine with MKVToolNix. Of course a lot of the checksums in my test suite change, but that's to be expected, and the resulting files seem to be processed further just fine as well.