Set CMAKE_CURRENT_BINARY_DIR as public

Matroska-Org / libmatroska

a C++ libary to parse Matroska files (.mkv and .mka)

GNU Lesser General Public License v2.1

318 stars 57 forks source link

Set CMAKE_CURRENT_BINARY_DIR as public #111

Closed asukiaaa closed 1 year ago

asukiaaa commented 1 year ago

I'm trying to build https://github.com/Azure/azure-storage-azcopy for ubuntu22.04

I can avoid errors of libebml by https://github.com/Matroska-Org/libebml/pull/140/files . I need the same chane for the libmatroska.

robUx4 commented 1 year ago

LGTM cc @mbunkus

mbunkus commented 1 year ago

I've solved this slightly differently in 44aefa8ff53562367100619cb79c949b2bb6b87e. It matches the change in libebml & removes the now superfluous PRIVATE.

Please give it a try & open a new bug if it doesn't solve your issue.

asukiaaa commented 1 year ago

Why do you steal my idea and contributon? You should do it after merge this PR.