search

Matroska-Org / libmatroska

a C++ libary to parse Matroska files (.mkv and .mka)
GNU Lesser General Public License v2.1
318 stars 57 forks source link

use assignment by reference instead of pointers #133

Closed robUx4 closed 8 months ago

robUx4 commented 8 months ago

No need to dereference a pointer.

robUx4 commented 8 months ago

Ah, I thought the operator was the preferred way. I had some troubles with it and ending up removing the factorization of those for now. If you think it's better not to have them at all, I can remove them for good.

mbunkus commented 8 months ago

We can leave the existing operator <whatever>() in the classes for compatibility purposes, but we should not really use them inside the library anymore. I'd even be fine with removing them altogether, even the member functions themselves.

robUx4 commented 8 months ago

Closing in favor of #136