Matsilagi / reshade-unity-shaders

Shaders ported from Unity Assets to ReShade
0 stars 0 forks source link

VHS PRO doesn't work on Reshade 4.3 #2

Open 77Mynameislol77 opened 5 years ago

77Mynameislol77 commented 5 years ago

VHSPro.fx(465, 46): error X3538: value must be a literal scalar expression VHSPro.fx(1019, 12): warning X3206: implicit truncation of vector type VHSPro.fx(1048, 12): warning X3206: implicit truncation of vector type VHSPro.fx(1657, 14): warning X3206: implicit truncation of vector type

Bapho commented 4 years ago

Hi @77Mynameislol77 @Matsilagi

Marot Satil from the GShade Team updated the code to work with ReShade 4+. I fixed another bug and updated the code in my repo: https://github.com/Bapho/reshade-shaders/blob/master/Shaders/VHSPro.fx

Mortalitas commented 4 years ago

Hi @77Mynameislol77 @Matsilagi

I fixed another bug and updated the code in my repo:

Outside of no longer defining the ui_min and ui_max ranges in quotes and changing the default value of tapeNoiseAmount from 1.0 to 0.05, was there anything else modified?

Bapho commented 4 years ago

Hi @77Mynameislol77 @Matsilagi I fixed another bug and updated the code in my repo:

Outside of no longer defining the ui_min and ui_max ranges in quotes and changing the default value of tapeNoiseAmount from 1.0 to 0.05, was there anything else modified?

yes, this is basically what i changed from the gshade code.

Mortalitas commented 4 years ago

Outside of no longer defining the ui_min and ui_max ranges in quotes and changing the default value of tapeNoiseAmount from 1.0 to 0.05, was there anything else modified?

yes, this is basically what i changed from the gshade code.

Cheers, just wanted to confirm.