search

Matsuuu / web-component-devtools

Web Component DevTools is a Browser Extension enhancing the development experience of Web Component developers
https://matsuuu.github.io/web-component-devtools/
MIT License
135 stars 3 forks source link

404 in custom-elements.json cause javascript debugger break #11

Closed timker closed 3 years ago

timker commented 3 years ago

missing custom-element.json make my debugger kick into action

maybe check res.ok before calling json()

image

Matsuuu commented 3 years ago

I wasn't able to reproduce the debugger getting triggered by this.

Could you provide a minimal example or a link to a site in which this happens?

And what is your debugger setup?

timker commented 3 years ago

Unfortunately the example site is behind a password, sorry

as far as dev tools set up, I ca't see anything weird

image

pause is unchecked

It seems to be intermittent today...?

Other Notes: there is an tiny service worker there are iframes

Matsuuu commented 3 years ago

Heya,

Could you try out with the latest version (0.1.2) and see if it still happens?

timker commented 3 years ago

Hey, Just tried in 0.1.3, still same issue.

timker commented 3 years ago

FYI, great naming for nydus.js

Matsuuu commented 3 years ago

Hey, thanks for checking in.

Unfortunately I'm not able to reproduce this.

Could you give clear steps on how you get this to happen?

Matsuuu commented 3 years ago

In the next version the fetch requests are done by a background script, which should eliminate these errors. I'll ping this ticket as it ships

Matsuuu commented 3 years ago

This should be fixed in 0.1.8

timker commented 3 years ago

hey ya, just re-enabled and 0.1.9 no longer has the issue.

Thanks for fixing, keep up the good work