search

Matsuuu / web-component-devtools

Web Component DevTools is a Browser Extension enhancing the development experience of Web Component developers
https://matsuuu.github.io/web-component-devtools/
MIT License
131 stars 3 forks source link

[BUG]: Certain apps cause an infinite loop #43

Closed e111077 closed 2 years ago

e111077 commented 2 years ago

Describe the bug

Certain apps like Angular cause an infinite loop when you open WC dev tools.

To Reproduce Steps to reproduce the behavior:

  1. Go to angular.io
  2. Open WC dev tools
  3. select the first element you see

Expected behavior

It not make my PC sound like it's mining crypto

Desktop (please complete the following information):

Additional context

They're not in the CE registry

Matsuuu commented 2 years ago

The angular context seemed to be quite a hefty object to iterate through for analysis and was causing the issues. I added a preliminary compatibility layer for angular here, but in it's current state it doesn't quite list everything we would maybe want it to list.

I'm not experienced with angular, nor do I have a demo project to test the tooling on, so if you have a demo project with say, 2 kinds of properties, a few attributes and a few events, I'd love to test / develop the angular support against it.

But the preliminary fix should resolve the infinite loop problem, and will be shipped in the next release.

Closing this as it's been resolved, but if you have a test site with angular components as described above, please do share it with me via github/slack/twitter :)