Code Notes

[busynest]

File: devtools-inspector-category

renderItem() > renderProperty() : Expected 2 arguments, but got 1. updateTimeout : Type 'null' is not assignable to type 'number'.

TypeScript declare type CustomEvent MESSAGE_TYPE

checkIfMutationIsRelevantReSelectEvent not used.

plus more

I already updated the project to TypeScript, and many errors are popping up

[Matsuuu]

There is some work in typing + docs i'm working on.

A full transition to TS will never happen though. It's purely a JS+ JSDoc project

[busynest]

• File: element-parsers > determineAttributes()

  The attribute name & type should be the same.

  let attribute = { name: attrName };
  attribute.type= determineAttributeType(attribute, element);

• File: content-messaging

  import "Nydus" (pointing to NO FILE) import "analyzer" (pointing to NO FILE)

• File: devtools-init

  import "Nydus" (pointing to NO FILE) tabSites not used

• File: context-menus

  import "Nydus" (pointing to NO FILE) onWebComponentInspect() 2 unused arguments

• File: dom-actions > removeUnsendableObjects()

  objects are being declared at function because reference does not exist

• File: devtools-console-view

  editor does not exist import "playground" does NOT exist

• devtools-property-indicators

  dir does not exist

• File: devtools-inspector + devtools-elements-list

  log() expects 3 arguments, got 2

• devtools-source-view

  import "playground" does not exist

• Custom Element: <devtools-text-input>

  nolabel does NOT exist

• FILE: property-editor-builder

  Missing import for devtools-object-input

• File: devtools-source-view

  custome element devtools-source-viewer does not exist

• File: devtools-combination-input

  Property checkedboxElem does NOT Exist _triggerInput expects 2 arguments, got 1

• File: devtools-checkbox

  missing import devtools-property-indicators

October 3

• File: background

  tabUpdateListener() @param {{ status: string; }} changeInfo if (changeInfo.status === 'complete') { changeInfo is a string but used as an object

@param {string | number} tabId tabSites[tabId] error is being thrown for tabId, I thnk it doesn't like numbers.

[busynest]

I think that is it for errors. But 2 patterns also show errors

1. CustomEvents have an object for first argument, I guess this works, but doesn't help declaring custom events.
2. const x = function(). This might be bad practice.