search

Matsyir / pvp-performance-tracker

External plugin for RuneLite: Tracks PvP performance by keeping track of various stats during combat
BSD 2-Clause "Simplified" License
4 stars 15 forks source link

add common pvp rings #43

Closed Macweese closed 3 weeks ago

Macweese commented 3 weeks ago

Many new rings now exist in the game, which are commonly used in PVP, but are not supported by the plugin. This PR intends to add the most prominent to the ring selection so that more accurate estimations may be given by the plugin.

Matsyir commented 3 weeks ago

As I mentioned in the other commit, I won't be entirely testing this, but many thanks for the PR.

I know nothing about all these new rings. I could go through the wiki for each, but I figure you'd know, so I'll just ask to be sure: are you certain that none of these rings have special effects to implement, which are notable for PvP? Or in other words, all their notable PvP stats/benefits come directly from stats which are included in the standard damage formula, and not special passive effects? For example, I know brimstone ring required some additional calculations for deserved damage in order to properly support its passive effect of occasionally ignoring magic defence.

It wouldn't be a huge deal if these aren't implemented properly for now, but it would be good to include those eventually if they do require any special calculation, like brimstone ring does.

Macweese commented 3 weeks ago

Yes, none of the rings added in this PR have any sort of passive effect which influence combat calculations. The only ring added with any passive effect is the forgotten ring, but that is in respect to functioning as a ring of visibility, and has no combat effects whatsoever.