Matt-Esch / virtual-dom

A Virtual DOM and diffing algorithm
MIT License
11.66k stars 779 forks source link

type checking with flow #320

Open Gozala opened 8 years ago

Gozala commented 8 years ago

I lately have being using http://flowtype.org to type check some of my libraries. I also have being using virtual-dom and a flow in the same project and lack of type annotations had being little painful. In order to make it little better for myself I also wrote set of type aliases for working with virtual-dom library: https://gist.github.com/Gozala/025b6478df81ff232b16

I was wondering if you would have any interest in integrating flow type checking into the virtual-dom library ? If not maybe you would be willing to add an interface files with type annotations for users that would like to use flow to type check code that uses virtual-dom library ?

I'd be willing to do the actual work.

Raynos commented 8 years ago

We already have a jsig file checked in. Adding an interface file should be fine.

Raynos commented 8 years ago

I think the source code has to be ES3. I dont think we can add flow type checking natively as its not ES3

kuraga commented 8 years ago

@Raynos we can done it in ES5, https://github.com/codemix/babel-plugin-typecheck