Virtual-dom: Removed PhantomJS dependency

Matt-Esch / virtual-dom

A Virtual DOM and diffing algorithm

MIT License

11.66k stars 779 forks source link

Virtual-dom: Removed PhantomJS dependency #449

Open ossdev07 opened 5 years ago

ossdev07 commented 5 years ago

Phantomjs is an unmaintained project. Removed phantomjs dependency from package.json. run-browser supports phantomjs hence removed it from devdependency.

Signed-off-by: ossdev07 ossdev@puresoftware.com

coveralls commented 5 years ago

Coverage remained the same at 97.531% when pulling a005964ea705339c714e35e8a165c83d063da467 on ossdev07:virtual__dom into 947ecf92b67d25bb693a0f625fa8e90c099887d5 on Matt-Esch:master.

coveralls commented 5 years ago

Coverage remained the same at 97.531% when pulling a005964ea705339c714e35e8a165c83d063da467 on ossdev07:virtual__dom into 947ecf92b67d25bb693a0f625fa8e90c099887d5 on Matt-Esch:master.

rhenwood-arm commented 5 years ago

I would like to see the phantomJS dependency removed. @Matt-Esch can you please provide feedback?

ossdev07 commented 4 years ago

Ping @Matt-Esch could you have a look at this PR?