Matt-Jensen / ember-cli-g-maps

Deprecated Google Maps Addon
http://matt-jensen.github.io/ember-cli-g-maps
MIT License
59 stars 31 forks source link

BUG: Browser crashes upon loading ember-cli-g-maps with new default JS API (v3.31) #108

Open eelke opened 6 years ago

eelke commented 6 years ago

Describe your environment

Describe the problem

Yesterday my client reported the site did no longer 'work', and in fact was crashing browsers. I managed to distill the problem back to the initiation of the g-maps component and the loading of the Google Maps JS API.

On the Google Maps Release Notes website I read that on February 13 (currently two days ago) Google has pushed a new version of the JS API live, v 3.31.

Specifically loading the previous version (v3.30) bypasses this issue.

Note: While on my local development machine this lead to no issues, on the staging and live servers entire browsers crash upon loading the g-maps component.

Steps to reproduce:

I personally use Ember in combination with PHP, and load the API through a direct URL and not the environment settings. <script src="//maps.googleapis.com/maps/api/js?sensor=false&v=3.30&key=API_KEY"></script>

Relevant Code:

  ENV.googleMap = {
    version: '3.30', // fixes the issue
    (...)
  }
Matt-Jensen commented 6 years ago

What is the error message and do you have an example application that's already live?

eelke commented 6 years ago

@Matt-Jensen I can send you a link to the live & staging servers in private, where to?

Matt-Jensen commented 6 years ago

@eelke I'm running version 3.31.8a on a production app just fine. Are you sure this issue occurs with a default Ember app running the latest version of this addon?