search

Matt-Jensen / ember-cli-g-maps

Deprecated Google Maps Addon
http://matt-jensen.github.io/ember-cli-g-maps
MIT License
59 stars 31 forks source link

Bind g-autocomplete options #76

Open JoannaFalkowska opened 7 years ago

JoannaFalkowska commented 7 years ago

Options like placeholder or options passed to g-autocomplete don't work correctly. The only things that functions property are on-select action and valuewhich are correctly passed. I'm using Ember CLI 2.8.0.

It can be very easily reproduced just with:

{{g-autocomplete placeholder='type country'}}

Any idea what's happening?

Also I see that it only consumes options passed in didInsertElement hook, that means that options can't be a computed property, right? What's the reason for this?

Matt-Jensen commented 7 years ago

I'm currently testing for existence of a placeholder here. Can you prove that test should be failing?

Matt-Jensen commented 7 years ago

Confirm placeholder works on element instantiation.

Changing issue name to: "bind g-autocomplete options" and adding enhancement label. Adding this to the v1 release.