Matt-Jensen / ember-cli-g-maps

Deprecated Google Maps Addon
http://matt-jensen.github.io/ember-cli-g-maps
MIT License
59 stars 31 forks source link

[FEATURE] Easier add, select, list, and remove #79

Closed realityendshere closed 7 years ago

realityendshere commented 7 years ago

Squashed commit of the following:

commit 87d59e98912d31e4cfaa0066a6df2236172e41c4 Author: Dana Franklin realityendshere@users.noreply.github.com Date: Tue Mar 14 20:21:31 2017 -0700

Add .refreshMap() convenience method to service

commit 0b299f1489807511ab146517d96a304919f7f77f Author: Dana Franklin realityendshere@users.noreply.github.com Date: Tue Mar 14 20:21:13 2017 -0700

Tests to handle some failures and .refreshMap()

commit 12540736ba3776373861150ce039051d946a771c Author: Dana Franklin realityendshere@users.noreply.github.com Date: Mon Mar 13 21:37:19 2017 -0700

Convenience methods for interacting with service

addMap(name, map) [instead of `service.maps.add(name, map)`]

list() [list map names]

removeAll() [reset the service, good for testing]

removeMap(name) [instead of `service.maps.remove(name)`]

selectMap(name) [instead of `service.maps.select(name).map`]

commit aecdbb9728415950f31a01890088c5ba8099b9b8 Author: Dana Franklin realityendshere@users.noreply.github.com Date: Mon Mar 13 21:27:48 2017 -0700

Expand g-map service tests

Test convenience methods
Test auto-naming
Test for expected errors (invalid name or map, duplicale name)
Reset service after each test (improves test predictability)
Matt-Jensen commented 7 years ago

Overall I really like what you've done. I've just changed some of the assertions to be strict instead of truthy and applied some of your tests to the original methods they proxy. Thanks for your help, definitely makes this service more robust.

realityendshere commented 7 years ago

Awesome. Thanks for the adjustments!

I am working with @cloke on some features for some work he's doing. I expect to be putting more work into this add-on soon!