Matt-Jensen / ember-cli-g-maps

Deprecated Google Maps Addon
http://matt-jensen.github.io/ember-cli-g-maps
MIT License
59 stars 31 forks source link

please adapt your code to last EmberJS releases #93

Closed EmberJSParis closed 7 years ago

EmberJSParis commented 7 years ago

Here is correct today

contentSecurityPolicy: {

'default-src': "'none'", 'script-src': "'self' 'unsafe-eval' .googleapis.com maps.gstatic.com", 'font-src': "'self' fonts.gstatic.com", 'connect-src': "'self' maps.gstatic.com", 'img-src': "'self' .googleapis.com maps.gstatic.com csi.gstatic.com", 'style-src': "'self' 'unsafe-inline' fonts.googleapis.com maps.gstatic.com" },

Matt-Jensen commented 7 years ago

I'm not really seeing the difference between your content security policy configuration and the one documented here: http://matt-jensen.github.io/ember-cli-g-maps/#/setup/index

Could you please elaborate on what the difference is and what is the issue you're seeking to address with the currently recommended configuration.

EmberJSParis commented 7 years ago

Hi Matt,

The code here as it is

ENV.contentSecurityPolicy = { 'default-src': "'none'", 'script-src': "'self' 'unsafe-eval' .googleapis.com maps.gstatic.com", 'font-src': "'self' fonts.gstatic.com", 'connect-src': "'self' maps.gstatic.com", 'img-src': "'self' .googleapis.com maps.gstatic.com csi.gstatic.com", 'style-src': "'self' 'unsafe-inline' fonts.googleapis.com maps.gstatic.com" };

produce error.

The correct code is

contentSecurityPolicy: {

'default-src': "'none'", 'script-src': "'self' 'unsafe-eval' .googleapis.com maps.gstatic.com", 'font-src': "'self' fonts.gstatic.com", 'connect-src': "'self' maps.gstatic.com", 'img-src': "'self' .googleapis.com maps.gstatic.com csi.gstatic.com", 'style-src': "'self' 'unsafe-inline' fonts.googleapis.com maps.gstatic.com" },

The ENV. should not be there

The issue is that web is full of small errors like that who poison the life of developers.

missing code everywhere like open <div id="mega-map »> but not close

etc https://github.com/binhums/ember-cli-mapbox

everywhere is time consuming

Le 16 juil. 2017 à 19:12, Matt-Jensen notifications@github.com a écrit :

I'm not really seeing the difference between your content security policy configuration and the one documented here: http://matt-jensen.github.io/ember-cli-g-maps/#/setup/index http://matt-jensen.github.io/ember-cli-g-maps/#/setup/index Could you please elaborate on what the difference is and what it's the issue you're seeking to address with the currently recommended configuration.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Matt-Jensen/ember-cli-g-maps/issues/93#issuecomment-315623023, or mute the thread https://github.com/notifications/unsubscribe-auth/AaWfsohUAow_IRRIRzsWWgISu19Yks9bks5sOkSPgaJpZM4OZRbE.

EmberJSParis commented 7 years ago

Matt,

I have a bigger issue while I get lost in these small issues

I have in a result route a loop like hereafter and I want to introduce longitude and latitude from this loop in the script hereafter

directly it doesn’t work so I thought to use the https://github.com/binhums/ember-cli-mapbox https://github.com/binhums/ember-cli-mapbox

but I am stuck in how to enter coordinates in your code

{{#mapbox-map mapId='ember-cli-mapbox.7c3914f2' as |map|}} {{#each positions as |position|}} {{mapbox-marker map=map coordinates=position.coordinates}} {{/each}} {{/mapbox-map}}

Hereafter is my code;

I try to enter the {{locdetail.loc_detail.longitude}} in the script

Can you help ? Should I use ember-cli-g-maps ?

How to solve position.coordinates for both longitude and latitude ?

Thanks

{{#each model as |locdetail|}}

  • URL: {{locdetail.url}}
      IP: {{locdetail.ip}}
      Longitude: {{locdetail.loc_detail.longitude}}
      Latitude: {{locdetail.loc_detail.latitude}}
      City: {{locdetail.loc_detail.city}}
      Organisation: {{locdetail.loc_detail.org}}
      Region: {{locdetail.loc_detail.region}}
      Country: {{locdetail.loc_detail.country}}
      Country Name: {{locdetail.loc_detail.country_name}}
      Timezone: {{locdetail.loc_detail.timezone}}
  • {{/each}}

    Le 16 juil. 2017 à 19:12, Matt-Jensen notifications@github.com a écrit :

    I'm not really seeing the difference between your content security policy configuration and the one documented here: http://matt-jensen.github.io/ember-cli-g-maps/#/setup/index http://matt-jensen.github.io/ember-cli-g-maps/#/setup/index Could you please elaborate on what the difference is and what it's the issue you're seeking to address with the currently recommended configuration.

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Matt-Jensen/ember-cli-g-maps/issues/93#issuecomment-315623023, or mute the thread https://github.com/notifications/unsubscribe-auth/AaWfsohUAow_IRRIRzsWWgISu19Yks9bks5sOkSPgaJpZM4OZRbE.

    Matt-Jensen commented 7 years ago

    @EmberJSParis I'm happy to help all developers in the Ember Slack weigh the pros and cons of decisions like this, but lets keep the conversation in this issue related to improving the recommended content security policy configuration of this project. I'm active in Slack so feel free to ping me there!

    EmberJSParis commented 7 years ago

    Dear Matt,

    I have not the link to Slack and is time consuming to correct all the small errors but I am more concerned by important issues like this one right now

    Matt,

    I have a bigger issue while I get lost in these small issues

    I have in a result route a loop like hereafter and I want to introduce longitude and latitude from this loop in the script hereafter

    directly it doesn’t work so I thought to use the https://github.com/binhums/ember-cli-mapbox

    but I am stuck in how to enter coordinates in your code

    {{#mapbox-map mapId='ember-cli-mapbox.7c3914f2' as |map|}} {{#each positions as |position|}} {{mapbox-marker map=map coordinates=position.coordinates}} {{/each}} {{/mapbox-map}}

    Hereafter is my code;

    I try to enter the {{locdetail.loc_detail.longitude}} in the script

    Can you help ? Should I use ember-cli-g-maps ?

    How to solve position.coordinates for both longitude and latitude ?

    Thanks

    {{#each model as |locdetail|}}

  • URL: {{locdetail.url}}
      IP: {{locdetail.ip}}
      Longitude: {{locdetail.loc_detail.longitude}}
      Latitude: {{locdetail.loc_detail.latitude}}
      City: {{locdetail.loc_detail.city}}
      Organisation: {{locdetail.loc_detail.org}}
      Region: {{locdetail.loc_detail.region}}
      Country: {{locdetail.loc_detail.country}}
      Country Name: {{locdetail.loc_detail.country_name}}
      Timezone: {{locdetail.loc_detail.timezone}}
  • {{/each}}

    Cristian BEZA | Chief Action Officer ARTEDYS | ARTADYS | Behavior, Personality, Attitudes, Loyalty, and Trend Tracking on the Internet | Strategy and Research ARTADYS & Buzz Analytics | Paris & Washington, DC | www.artadys.com

    LinkedIn: http://www.linkedin.com/in/CristianBeza

    "A plan without action is not a plan. It's a speech."

    Thomas Boone Pickens (Consultant billionaire )

    Le 16 juil. 2017 à 20:01, Matt-Jensen notifications@github.com a écrit :

    @EmberJSParis I'm happy to help all developers in the Ember Slack weigh the pros and cons of decisions like this, but lets keep the conversation in this issue related to improving the recommended content security policy configuration of this project. I'm active in Slack so feel free to ping me there!

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

    Matt-Jensen commented 7 years ago

    @EmberJSParis sorry I'm just not that familiar with ember-cli-mapbox and just wouldn't be of any help to you in this regard. Why not ping binhums? Or reach out to him on Slack? Sure he'd love to help you with this.

    EmberJSParis commented 7 years ago

    Is OK Matt I thought you were at the origin of ember-cli-g-maps Thanks anyway

    Cristian BEZA | Chief Action Officer ARTEDYS | ARTADYS | Behavior, Personality, Attitudes, Loyalty, and Trend Tracking on the Internet | Strategy and Research ARTADYS & Buzz Analytics | Paris & Washington, DC | www.artadys.com

    LinkedIn: http://www.linkedin.com/in/CristianBeza

    "A plan without action is not a plan. It's a speech."

    Thomas Boone Pickens (Consultant billionaire )

    Le 16 juil. 2017 à 20:31, Matt-Jensen notifications@github.com a écrit :

    @EmberJSParis sorry I'm just not that familiar with ember-cli-mapbox and just wouldn't be of any help to you in this regard. Why not ping binhums? Or reach out to him on Slack? Sure he'd love to help you with this.

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.