search

Matt12yearslater / max-hit

Tells the player their max hit in their current gear
BSD 2-Clause "Simplified" License
3 stars 12 forks source link

Dinh's Bulwark not supported #28

Open sumsare opened 6 months ago

sumsare commented 6 months ago

Dinh's bulwark has a special effect of gaining extra strength bonus based on your stab, slash, crush and ranged defences. The formula is very straightforward:

image

Now I don't know how the plugin calculates your max hit (I'm assuming in the case of melee attacks, it gets your str level, active prayers and your melee str so I don't see why it couldn't also get your defensive stats and apply the formula and add it onto the melee str stat?

I do understand that the bulwark isn't really used as a dps weapon but it'd still be nice to see the max hit.

sumsare commented 6 months ago

Actually, I found out that the formula is already applied to your MELEE STR stat on the equipment screen (cos if you unequip armour that doesn't have any melee str bonus directly attacked to it, your melee str stat goes down when wearing the bulwark) so now I'm wondering how the plugin calculates the max hit in the first place? by using fixed stats of the items pulled from wiki rather than actually checking the stats of your player character? See this image

compared to this image

Seebity commented 5 months ago

Unfortunately, melee/ranged/magic strength has to be calculated manually in Runelite plugins, we can't just grab it from the character otherwise that would make this plugin 5x less complicated. I started refactoring and updating this plugin around a year ago but stopped along the way. I mean to create another pull request by the end of this year or submit my own plugin labeled as "V2" or some sort cause this plugin was the foundation. Be on the lookout for it!

sumsare commented 5 months ago

Unfortunately, melee/ranged/magic strength has to be calculated manually in Runelite plugins, we can't just grab it from the character otherwise that would make this plugin 5x less complicated. I started refactoring and updating this plugin around a year ago but stopped along the way. I mean to create another pull request by the end of this year or submit my own plugin labeled as "V2" or some sort cause this plugin was the foundation. Be on the lookout for it!

I see, thanks for letting me know!