Smoke battlestaff magic bonus cannot work

[domien96]

line 599 if (weaponName().contains("moke battle") && config.spellChoice().spellbook == Spellbook.NORMAL) { magicEquipmentBonus += 10; } The second condition is never true because config.spellChoice().spellbook will always be Ancient. I wonder if this ever worked at all.

[Seebity]

Are you thinking of the Ancient Staff?

Per the wiki, "The staff provides a 10% increase in accuracy and damage when casting spells from the standard spellbook;"

https://oldschool.runescape.wiki/w/Smoke_battlestaff

[domien96]

No, the smoke battlestaff gives a 10% bonus when using normal spellbook. There is an issue with checking the spellbook. Now look at line 599, it checks two conditions:

1. The player wears the staff
2. It checks if config.spellchoice().spellbook is equal to the normal spellbook

Looking further, I note that config.spellchoice() is hardcoded to ice barrage, meaning the second condition will always evaluate as ancient == normal, which will be false anytime.

[Seebity]

config.spellchoice() is defaulted to barrage, not hard coded. Are you having troubles with this while running?

[caleblee9]

@domien96 Do you think there's still an issue or did I answer your question?