search

Matt12yearslater / max-hit

Tells the player their max hit in their current gear
BSD 2-Clause "Simplified" License
3 stars 12 forks source link

Prayer Bonus Inconsistency #4

Open whartd opened 3 years ago

whartd commented 3 years ago

It looks like the prayer bonus for equipped weapons is calculated based on activated prayers, but the prayer bonus for inventory weapons is assuming the highest prayer is active. Is there a reason for that inconsistency? I see the code says "have to assume using best prayer for level" but I'm not sure why that is.

The two alternatives I think would be better would be:

1) Both inventory weapons and equipped weapons calc max hit based on currently activated prayer

OR

2) Both inventory weapons and equipped weapons calc based on a selected prayer in the config. This would be my preferred solution, and would be a bit more similar to how the the google sheets dps calc works. There could even be an option there for "currently activated prayer."

Matt12yearslater commented 3 years ago

I like the idea of making it optional, the reason I assumed it is because I made it thinking about a pvp setting, so doing range to melee for example is what this feature addresses.

I also like the idea of making a bunch of toggles for strength level and prayer, even strength bonus like how the online tool works. Ngl I was just kind of lazy and didn’t feel like putting in all of that as well but it would definitely be a good addition, like a ‘theoretical max hit’ section