Closed waldo323 closed 10 years ago
Friendly amendment: The form says "All Weekend" and nowhere does it say "All Day". But other than that, yes, "5 hrs" is still a bug.
"All Weekend" is the 5th radio button option and its value is "5". This means we are wrongly giving the time based on the radio value. The 4th radio option is "more" and its value is "4", which means it would wrongly show up as "4 hours".
Selecting the "More" radio button should result in printing "More than 3 hrs" to the event listing, and a value of "All weekend" should result in printing "All weekend" to the event listing.
good catch
James
On Tue, May 6, 2014 at 1:35 PM, MattArnold notifications@github.com wrote:
Friendly amendment: The form says "All Weekend" and nowhere does it say "All Day". But other than that, yes, "5 hrs" is still a bug.
"All Weekend" is the 5th radio button option and its value is "5". This means we are wrongly giving the time based on the radio value. The 4th radio option is "more" and its value is "4", which means it would wrongly show up as "4 hours".
Selecting the "More" radio button should result in printing "More than 2 hrs" to the event listing, and a value of "All weekend" should result in printing "All weekend" to the event listing.
— Reply to this email directly or view it on GitHubhttps://github.com/MattArnold/penguicontrax/issues/145#issuecomment-42333728 .
Fixed with commit fea471d73409d0f009912932ec98e410322bfa54
I submitted an "All Day" event. The intention is for the event to be an All Day and All Weekend event(I think all day generally means all weekend as well but this isn't clear from the form - more from my understanding of how past conventions have worked).
On the main page it shows 5 hrs for the duration rather than All Day or All Day and All Weekend.