search

MattCallahan-NOAA / rmisr

An R package for accessing RMIS code wire tag data.
2 stars 2 forks source link

getting location info from catch sample #3

Closed marksorel8 closed 5 months ago

marksorel8 commented 6 months ago

Any idea what fields you would use from the catch sample data to join it with information on the location?

MattCallahan-NOAA commented 6 months ago

@gregwilke I am going to punt this to you.

gregwilke commented 6 months ago

Hi Mark, The Catch sample data has a field called catch_location_code and location has location_code with a location_type=2 (for catch sample). That would be the primary connection in general. You can see API docs here: https://phish.rmis.org/docs/static/index.html, and you can find the RMIS data specification here (search for specification): https://www.rmpc.org/resources/documents/.

Also, you can direct questions about the RMIS project and RMIS data to me. I work with the project, Matt is the R script guru who helped us by building this package.

Greg

marksorel8 commented 6 months ago

So when I run the get_catchsample() function, the object that is returned does not include a catch_location_code field. Any idea why that may be?

gregwilke commented 6 months ago

Yes, issue confirmed. I was just looking at the schema for the initial response. There is some special treatment applied to this field and it is not being included in the output. I'll look at this tomorrow and let you know when we have a fix.

Appreciate you letting us know.

-----Original Message----- From: mark sorel @.> Sent: Monday, April 15, 2024 7:31 PM To: MattCallahan-NOAA/rmisr @.> Cc: Greg Wilke @.>; Mention @.> Subject: Re: [MattCallahan-NOAA/rmisr] getting location info from catch sample (Issue #3)

    You don't often get email from ***@***.*** Learn why this is important <https://aka.ms/LearnAboutSenderIdentification>

CAUTION: This email originated from outside of PSMFC. Do not follow guidance, click links, or open attachments unless you recognize the sender and know the content is safe.

So when I run the get_catchsample() function, the object that is returned does not include a catch_location_code field. Any idea why that may be?

- Reply to this email directly, view it on GitHub https://github.com/MattCallahan-NOAA/rmisr/issues/3#issuecomment-2058122915 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQIIBLOL3G3WC3CLG4WBSRDY5SEQDAVCNFSM6AAAAABGIHISFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGEZDEOJRGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AQIIBLMKPILWGYPUL4QW6IDY5SEQDA5CNFSM6AAAAABGIHISFSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT2VR3KG.gif Message ID: @.***>

gregwilke commented 5 months ago

I updated the catch sample data category and it is outputting the catch_location_code as intended with my testing now. Please let me know if that is not the case for you.

Greg

marksorel8 commented 5 months ago

I can confirm that the catch_location_code is now a field in the data returned by the get_catchsample() function. Thank you!