search

MattCowgill / ggannotate

Interactively annotate ggplots
Other
309 stars 20 forks source link

Added geom_rect support for drawing rectangles #33

Closed jhelvy closed 4 years ago

jhelvy commented 4 years ago

I didn't mean to add the latest commit to this PR - I was just experimenting with a tabbed UI, putting the code to copy on a separate tab and rearranging a bit of the main annotation tab layout.

MattCowgill commented 4 years ago

hi @jhelvy this is good, thank you! I like the move of the plot size options to underneath the plot. Not 100% sure about the tabbed UI for code, but I agree it's probably better than what I had. I've been thinking about going with something similar to esquisse:esquisser() for that part of the UI.

jhelvy commented 4 years ago

Ooo esquisse:esquisser() is slick - very nice UI for exporting the code. I like the idea of having it as a pop-up rather than a separate tab.

MattCowgill commented 4 years ago

Thanks @jhelvy. There are a few things I want to tweak, but it won't let me push to jhelvy/ggannotate to update the PR, so I'll accept this and push to master.