Closed hamgamb closed 2 years ago
Hi @hamgamb, yes please! I thought I’d found all the xls-specific code but looks like you’ve found some more.
Could you put through a PR? Thanks so much
(I’d make this change but I’m out for the day without my laptop)
Happy to do so. Likely after lunch
Hi Matt!
I'm sure you already know. The ABS is changing to .xlsx (progressively) for time series spreadsheets.
Could the below be changed to
pattern = "\\.(xls|xlsx)$"
. I did some quick tests and it seemed to work.https://github.com/MattCowgill/readabs/blob/47c73f43a12e63821df5c0b51f8b38d3959d4a76/R/read_abs_local.R#L113