search

MattCowgill / readabs

Download and tidy time series data from the Australian Bureau of Statistics in R
https://mattcowgill.github.io/readabs/
Other
101 stars 22 forks source link

Changes to Excel file format on the ABS website #179

Closed hamgamb closed 2 years ago

hamgamb commented 2 years ago

Hi Matt!

I'm sure you already know. The ABS is changing to .xlsx (progressively) for time series spreadsheets.

Could the below be changed to pattern = "\\.(xls|xlsx)$". I did some quick tests and it seemed to work.

https://github.com/MattCowgill/readabs/blob/47c73f43a12e63821df5c0b51f8b38d3959d4a76/R/read_abs_local.R#L113

MattCowgill commented 2 years ago

Hi @hamgamb, yes please! I thought I’d found all the xls-specific code but looks like you’ve found some more.

Could you put through a PR? Thanks so much

MattCowgill commented 2 years ago

(I’d make this change but I’m out for the day without my laptop)

hamgamb commented 2 years ago

Happy to do so. Likely after lunch