codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04 :tada:
Comparison is base (
151a7e4) 88.74% compared to head (6e3994f) 88.79%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #235 +/- ## ========================================== + Coverage 88.74% 88.79% +0.04% ========================================== Files 29 29 Lines 1253 1258 +5 ========================================== + Hits 1112 1117 +5 Misses 141 141 ``` | [Impacted Files](https://app.codecov.io/gh/MattCowgill/readabs/pull/235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matt+Cowgill) | Coverage Δ | | |---|---|---| | [R/read\_job\_mobility.R](https://app.codecov.io/gh/MattCowgill/readabs/pull/235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matt+Cowgill#diff-Ui9yZWFkX2pvYl9tb2JpbGl0eS5S) | `96.87% <100.00%> (+0.57%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Issue described here: https://github.com/MattCowgill/readabs/issues/234
ABS TSD is returning broken links to xls files. The same urls with "x" appended at the end (as in ".xlsx") work. This small PR ensures that
read_abs()will try .xlsx before failing.Note that the error here is on the ABS side, not with {readabs}. But this should work around the problem.