search

MattCzyr / EnderMail

Ender Mail is a Minecraft mod that allows players to deliver packages anywhere in the world.
https://www.curseforge.com/minecraft/mc-mods/ender-mail
Other
11 stars 12 forks source link

Return package to sender upon sending to an invalid locker address #25

Closed grundyboy34 closed 3 years ago

grundyboy34 commented 3 years ago

I've noticed that if you send a package to a locker ID in which no locker exists, the package simply gets sent to whatever was placed in the coordinates part of the address (or near world spawn if those were blank). I find this very non-intuitive compared to how the average person would expect mail to work, and as typos can easily occur without catching them.

I'd suggest one of the two fixes: 1) When entering a Locker ID, change the GUI to disable the send button until a valid ID is entered. 2) When the enderman picks up the package, he simply brings the package back if he couldn't find a locker with the ID.

After looking into the code a bit, it seems option 2 may have the least required effort.

MattCzyr commented 3 years ago

Has been implemented in version 1.2.0.