search

MattCzyr / RealisticTorches

A Minecraft mod that causes torches to burn out after a configurable amount of time.
https://www.curseforge.com/minecraft/mc-mods/realistic-torches
Other
26 stars 12 forks source link

Unlit torches have the same light level as lit torches an optifine incompatibility 1.16.4 #34

Closed Magnetron64 closed 3 years ago

Magnetron64 commented 3 years ago

Minecraft 1.16.4 forge + optifine Current behavior: current Expected behavior: expected Same thing with dynamic lighting when held in hand the unlit torch emits light.

MattCzyr commented 3 years ago

Do unlit torches emit light when they are first placed, or only after they are lit then extinguished?

jj618 commented 3 years ago

I have the same issue. Realistic torches emit light when they are placed. I tried to remove shaders and ressource pack but same result. Minecraft 1.16.4 Forge 35.1.36 Optifine preview_OptiFine_1.16.4_HD_U_G6_pre12

Magnetron64 commented 3 years ago

They emit light after extinguished or placed for the first time (basically always) for me

MattCzyr commented 3 years ago

Let me know if this beta version fixes the issue:

https://www.dropbox.com/s/i3oc883her98pv9/RealisticTorches-1.16.4-3.1.1-beta.jar?dl=0

jj618 commented 3 years ago

It works for me. I tested:

So far so good. Nice work.

One question: Is it on purpose that the torch can't be taken back after breaking?

MattCzyr commented 3 years ago

One question: Is it on purpose that the torch can't be taken back after breaking?

What do you mean?

jj618 commented 3 years ago

One question: Is it on purpose that the torch can't be taken back after breaking?

What do you mean?

I mean that ordinary when you left click on a torch on a wall, the torch break and you can get the torch back but with the realistic torch, i get nothing. The realistic torch seems to fall through the floor and disappear.

jj618 commented 3 years ago

I noticed something else, with RealisticTorches-1.16.4-3.1.1-beta.jar, lit realistic torches in hand doesn't emit light anymore.

MattCzyr commented 3 years ago

Both the original issue and the issue with torches not dropping anything should be fixed as of version 3.1.1. Not sure about the handheld lighting issue, but I'll look into it.

jj618 commented 3 years ago

I tested RealisticTorches-1.16.4-3.1.1 and everything work has intended: