MattCzyr / RealisticTorches

A Minecraft mod that causes torches to burn out after a configurable amount of time.
https://www.curseforge.com/minecraft/mc-mods/realistic-torches
Other
26 stars 12 forks source link

Sugg-issue? #9

Open lumagatto opened 7 years ago

lumagatto commented 7 years ago

What happens when i have dynamic lights on and a lit torch in the hand? I can see in the darkness forever without making no new torches. It would be better if when lighted up torches (items) get a value (60 by default, should replace the 72000 ticks in the config) that goes down by 1 every 60 seconds. When you place the torch, it will still have that value. But the most important thing will be that these 60 seconds will not be stored in every torch, but in a global timer that every 60 seconds subtracts 1 from every torch (item or block) in the world. Could this system improve performance? It would surely fix that dynamic lights cheating. Thanks for making that small but really good mod. P.S. Torches could also be lighted by right clicking on a fire/lava with it, heating it in a furnace, and right clicking on them with flint&steel or other torches (I don't know if flint&steel already works...).

MattCzyr commented 7 years ago

This is something that I have been considering for some time but have not yet started implementing, or even started seeing if it's feasible. It would certainly not improve performance, though. This would only be one more factor to take into consideration when handling dynamic lighting, so in theory it would be a slower process (not noticeably, though). But I like the idea. It will likely end up in the mod at some point, but for the time being I am working on finishing up several other projects.

You can use already flint and steel to light torches. As for the other options, this is a fairly common suggestion that I get. Until now my decision has been no, as it sort of makes the matchbox/flint and steel lighting method obsolete later on. Seeing how popular of a suggestion it is, though, I will take it into further consideration.

Thank you for the suggestions!

lumagatto commented 7 years ago

Why should not be an improvement for performance? Now it does not add 1 tick to any existing torch 20 times per second? I tought that now it worked like, for 10 torches loaded, it changed the states of the torches 20 times per second, with 12000 changes in a minute. My idea was to have only 70 changes per minute, with 60 being the 60 seconds and 10 the number of changes to the torches done when reaching 60 seconds. You know this better than me of course, could you explain why it would be worse?