search

MattEqualsCoder / MSURandomizer

A multi game MSU randomizer that supports SMZ3, ALttPR, and VARIA
MIT License
1 stars 1 forks source link

"Compatible" hides valid MSU #12

Closed Alaszun closed 1 year ago

Alaszun commented 1 year ago

Hey, not really sure how to debug or provide appropriate information here, but if I have the filter set to "Compatible" it's hiding MSUs that I have used as valid MSUs in ALTTP before.

Specifically I am using the Sonic 2 MSU, and it gets filtered out with compatible on. If I set the filter to "All" it will show up, and if I use it it works correctly.

Alaszun commented 1 year ago

I should probably have written this better. If you look at the UI it does show as "Unknown" instead of Link to the Past.

image

I guess the question here is why is this MSU which is a valid ALTTPR MSU is showing as unknown. Is it looking for specific files? image

MattEqualsCoder commented 1 year ago

Won't bore you with the details, but I think what's most likely the issue is with how I try to distinguish between Super Metroid MSUs with the future extended tracks and Z3 MSUs. I'm overhauling the way all this works in the next version so that it'll hopefully be better. Worst case scenario, I'm adding in a function into the next version for you to be able to override default MSU types.

That being said, there shouldn't be much of a downside of selecting Unknown tracks until the new version comes out in a couple weeks.

(BTW, nice choices with Steins;Gate and Umineko MSUs 👍)

Alaszun commented 1 year ago

I'm glad you like them! The S;G is a personal one I made (the Danganronpa is also a personal one, not Zelga's one)--I don't think anyone else has actually taken that one on. The Umineko one I just love the music from that series so much.

This is a small potatoes thing and not a problem to deal with at all, just figured if something was broken you'd probably want to know. Sounds like you're aware and it won't matter. Thanks for the response!

MattEqualsCoder commented 1 year ago

I've created a release candidate here: https://github.com/MattEqualsCoder/MSURandomizer/releases/tag/v0.9.7-rc.1

The MSU detection is completely different and may not work in 100% of cases still because there are some unusual corner cases where people do things differently, but you can now override the MSU type if needed. Let me know if you run into any problems.