search

MattEqualsCoder / MSUScripter

Application for creating MSUs and related files
MIT License
5 stars 2 forks source link

Better compatibility with non-44.1 kHz tracks #104

Closed Vivelin closed 5 months ago

Vivelin commented 6 months ago

Now, I assume either PyMusicLooper or msupcm++ (or both) implicitly convert tracks to 44.1 kHz. This is fine for the end result and previews, but when trying to find loop points manually for 48 kHz tracks, this is kind of a pain in the ass.

Assuming this is indeed some issue internal to the dependencies that you can't work around with a parameter or flag of some kind, would it be possible to show a warning for non-44.1 kHz tracks and automatically convert any entered samples? Obviously, this might result in some inaccuracies which is why I'd argue for a warning message of some kind, even when you do automatically convert it.

Vivelin commented 5 months ago

Discussed in Discord, this is an issue with Audacity 3.3 and up actually implicitly converting to 44.1 kHz by default, regardless of which track you opened.

A warning about this might be good, though. Maybe in the Trim End / Loop Start tooltips or something? Or just the readme, idk.

MattEqualsCoder commented 5 months ago

My current thought is to put a little thing in the top right after selecting a non-44100Hz file or if you add multiple files due to what Phiggle said: image