MattFaus / CrowdTube-Connector

A utility that syncs subtitles (a.k.a. captions) between YouTube and CrowdIn.
MIT License
1 stars 0 forks source link

CrowdIn exports all strings #2

Open MattFaus opened 11 years ago

MattFaus commented 11 years ago

When building the CrowdIn all.zip, the code should instruct CrowdIn to only export the translated and approved strings, but it seems to be exporting everything, completely disregarding these two settings.

We need to figure out how to make CrowdIn respect the settings, or do our own filtering within the syncing script. Checking for translated status should be as easy as comparing msgid to msgstr. If they are the same, it has not been translated, otherwise, it has. Checking for "approved" status may be more difficult.

tzjames commented 11 years ago

I assume that you are doing something similar to what is done in download_i18n? ... retval = requests.post(_build_api_url('edit-project'), data={'export_approved_only': str(int(approved_only))})

csilvers commented 11 years ago

Hmm, I've not seen a problem with this before. When you visit http://crowdin.net/project/khanacademy/settings, after having it wrongly downloaded everything, what does it say for "Do not export untranslated" and "Export only approved"?

We are very careful to leave "Do not export untranslated" unchecked for our project, since if it's checked, it messes up html. If you decide to change that setting, be very very certain you set it back again when you are done.

csilvers commented 11 years ago

(I guess we could have the subtitles be a separate crowdin project, actually, in which case we wouldn't need to worry about that setting.)