MattFenelon / heroku-buildpack-ruby-poppler

A Heroku buildpack for the poppler library
Apache License 2.0
3 stars 6 forks source link

add flags when configuring the flex compilation #6

Closed did closed 4 years ago

did commented 4 years ago

I'm sorry, I've created my PR too soon :-( I'm just testing it right now.

did commented 4 years ago

alright, no more segmentation fault with this PR.

MattFenelon commented 4 years ago

Hi @did. Thanks for the PR. Could you give some detail on what the CFLAGS do?

did commented 4 years ago

you're welcome. No idea about what the CFLAGS do exactly :-) People here https://github.com/westes/flex/issues/442 just told that it fixed the segmentation fault issue.

MattFenelon commented 4 years ago

Fair enough! The flags look fairly innocuous so I'm merging this now. Thanks.