MattGibney / DarkThrone

Lovingly re-creating the DarkThrone experience.
https://darkthronereborn.com
1 stars 0 forks source link

Fix local build failures for react apps. #26

Closed MattGibney closed 4 months ago

MattGibney commented 4 months ago

Prior to my upgrade of NX to V18 we had to use file replacement for the production config of web apps. This sucked. With v18 they added proper support for Vite and environment variables, they also deprecated the file replacement approach.

This change replaced the file replacement approach with the new (and objectively better) env var approach.

Note: When I did the migration for my work a few weeks ago this didn't come up as we are using Webpack, not Vite